[Debug] less intrusive work around for https://bugs.php.net/54275 #10799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @internal | ||
| */ | ||
| class ErrorHandlerCanary |
There was a problem hiding this comment.
|
this looks much better than the previous implementation. That's great |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Apr 28, 2014
…t/54275 (nicolas-grekas) This PR was merged into the 2.5-dev branch. Discussion ---------- [Debug] less intrusive work around for https://bugs.php.net/54275 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10787, #10292 | License | MIT | Doc PR | none - This PR supersedes the behavior introduced in #10725 : Instead of building some complicated code to work around https://bugs.php.net/54275, the code is now as straightforward as possible, with a conditional fallback work around. - The handling of fatal errors is also made more robust/fail-safe. - Last but not least, ErrorsLoggerListener and FatalErrorExceptionsListener are now registered earlier and are now cleaning up their handler/logger once set to prevent setting again and again for sub-requests (+remove one refcount for these handler and logger). Commits ------- d7a186f [Debug] less intrusive work around for https://bugs.php.net/54275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of building some complicated code to work around https://bugs.php.net/54275, the code is now as
straightforward as possible, with a conditional fallback work around.
are now cleaning up their handler/logger once set to prevent setting again and again for sub-requests
(+remove one refcount for these handler and logger).