[Translation] Added unescaping of ids in PoFileLoader #11238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
May be i should add tests for |
|
@JustBlackBird quotes are fine. I'd rather add tests for plurals (see my PR, but use quotes like in your case). |
|
Since this is a bug fix, it should be merged into 2.3. |
|
@jakzal I'll add tests for plurals. Should I close this PR and create a new one to 2.3 branch? |
|
@JustBlackBird no need for closing. I only left the message as a reminder. We can still merge it to 2.3. |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @JustBlackBird. |
fabpot
added a commit
that referenced
this pull request
Jul 4, 2014
…tBlackBird) This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes #11238). Discussion ---------- [Translation] Added unescaping of ids in PoFileLoader | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Although it is not directly described in gettext docs, _msgid_ should be unescaped too. The other reason to unescape _msgid_ is symmetry between ```PoFileLoader``` and ```PoFileDumper```. The dumper escapes both _msgid_ and _msgstr_ values, but the loader unescapes only _msgstr_. Commits ------- 816a4a9 [Translation] Added unescaping of ids in PoFileLoader
|
You are welcome, @fabpot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it is not directly described in gettext docs, msgid should be unescaped too. The other reason to unescape msgid is symmetry between
PoFileLoaderandPoFileDumper. The dumper escapes both msgid and msgstr values, but the loader unescapes only msgstr.