Yaml: Escaping goes wrong somewhere

[Jille]

  $data = "\ttest\\n";
  $yamlstr = \Symfony\Component\Yaml\Yaml::dump($data);
  $parsed = \Symfony\Component\Yaml\Yaml::parse($yamlstr);
  var_dump($data, $yamlstr, $parsed);
  assert($data === $parsed);

string(7) " test\n"
string(10) ""\ttest\n""
string(6) " test
"
Assertion failed: $data === $parsed

I've added it to the test-framework with bdee3e4. I don't have phpUnit installed so I haven't tried them. Could you please check once again I didn't make any mistakes in it?

[stof]

hmm, looks like the \ is not escaped properly in the double-quoted strings

[xabbuh]

Hm, this seems to be done on purpose (see this test). Though I'm not sure that this is correct.

[stof]

nope, in this test, the original string does not contain a backslash. it contains CRLF (i.e. \r\n in PHP double-quoted strings), which are dumped as \r\n in YAML (which is available on the left in the array, in a single-quoted PHP string)

[xabbuh]

@stof Thanks, you're right. I didn't know that YAML supports them and I didn't look into the specs. :( So, if I'm not wrong, the backslash before the "n" needs to be properly escaped by the dump() call, right?

[stof]

not in the test you linked. But in the example reported in the issue, yes. All \ should be escaped in double-quoted strings, which seems to be broken currently

[xabbuh]

@stof Thank you. I'll try to fix it.