[YAML] properly mask escape sequences in quoted strings #11850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Sep 4, 2014
xabbuh
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #11789 |
| License | MIT |
| Doc PR |
|
shoudn't this be handled by the escaping of backslahes already ? It is actually a matter of a backslash followed by another char |
|
hmm, actually, we are only escaping doubled backslahes, which is wrong IMO. we should escape all backslashes to be safe Btw, your own list is incomplete. There is more escaped chars in YAML: http://www.yaml.org/spec/1.2/spec.html#id2776092 |
|
You're right. I tried escaping first which didn't work. But I guess that was simply a matter of where they have been placed. |
|
I think it is a matter of replacing the first element to escape single backslahes |
|
I modified the escaper. This should now work as expected. |
|
And I added some more tests (mainly to ensure that constructs like |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Sep 5, 2014
…abbuh) This PR was merged into the 2.3 branch. Discussion ---------- [YAML] properly mask escape sequences in quoted strings | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11789 | License | MIT | Doc PR | Commits ------- a7d0cf2 properly mask escape sequences in quoted strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.