Fix a web profiler form issue with fields added to the form after the form was built #13166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it not a duplicate? |
| @@ -420,7 +420,7 @@ | |||
| {% else %} | |||
| <div class="toggle-icon empty"></div> | |||
| {% endif %} | |||
| {{ name|default('(no name)') }} {% if data.type is not empty %}[<abbr title="{{ data.type_class }}">{{ data.type }}</abbr>]{% endif %} | |||
| {{ name|default('(no name)') }} {% if data.type_class is defined %}[<abbr title="{{ data.type_class }}">{{ data.type }}</abbr>]{% endif %} | |||
There was a problem hiding this comment.
we still need to check for data.type being empty
There was a problem hiding this comment.
Ok. I will change it in the other place too.
This make the check consistent with a similar check in this template made further down, and fixes an issue with fields added to the form after the form was built.
jakzal
force-pushed
the
bugfix/form-web-profiler
branch
from
d49de0d
to
1e794ca
Compare
|
This only prevents an exception. It doesn't really fix the root cause as the type won't be shown. I still think it should be merged. |
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Dec 30, 2014
…m after the form was built (jakzal) This PR was merged into the 2.6 branch. Discussion ---------- Fix a web profiler form issue with fields added to the form after the form was built | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no, but not because of this PR | Fixed tickets | #13155 | License | MIT | Doc PR | - This also make the check consistent with a similar check in this template made further down: * check for `data.type_class`, instead of `data.type` * check if `data.type_class` is defined rather than if it's empty The problem doesn't exist in 2.5. Commits ------- 1e794ca Check if a field type_class is defined before using it.
nicolas-grekas
added a commit
that referenced
this pull request
Dec 12, 2016
…lds added to the form after the form was built (tgalopin) This PR was merged into the 3.2 branch. Discussion ---------- [WebProfilerBundle] Fix a web profiler form issue with fields added to the form after the form was built | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20823 | License | MIT | Doc PR | - I discovered a bug in 3.2 in the web profiler and this PR fixes it. This issue has been fixed in the past by #13166 and probably reintroduced by the refactoring we did in the WebProfiler in 3.2. I simply applied the fix to these changes. To reproduce the original problem, simply clone the current standard edition, create a Form with a Type and add a field after its creation. Once done, try to access the Webprofiler: it will fails with the following error: > Key "type_class" for array with keys "id, name, view_vars, children" does not exist in @WebProfiler/Collector/form.html.twig at line 460. Commits ------- d9af8e9 Fix a web profiler form issue with fields added to the form after the form was built
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also make the check consistent with a similar check in this template made further down:
data.type_class, instead ofdata.typedata.type_classis defined rather than if it's emptyThe problem doesn't exist in 2.5.