[Routing][3.0] change constant values of UrlGeneratorInterface #14672
Labels
Comments
|
Considering constant values will not be part of the BC promise, we can even do this in 2.x. Ref. symfony/symfony-docs#5672 |
|
I agree. |
fabpot
added a commit
that referenced
this issue
Oct 19, 2015
…hp templates consistent with twig (Tobion) This PR was merged into the 2.8 branch. Discussion ---------- Unify URL generator reference type + make linking in php templates consistent with twig | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #14672 | License | MIT | Doc PR | TODO Please see ticket. Please merge #16277 first. I will then rebase this to make tests pass. Commits ------- 388fa43 [Templating] deprecate low-level RouterHelper::generate method as it's cumbersome to use constants in templates 97d6828 [Templating] introduce path and url methods in php templates to be in line with twig templates 912fc4d [Routing] deprecate the old url generator reference type values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the UrlGeneratorInterface has
@param bool|string $referenceType The type of reference to be generated (one of the constants). So a typebool|stringfor historic BC reasons which is bad especially considering possible future scalar type hints.So we should change the values of the constants (probably to int) in symfony 3.0. In PHP code, people should be using the constants for calling code anyway. And for twig, there are helpers (
urlandpathwhich both have arelativeboolean parameter. So they are not influenced. The main change would be for PHP templates using the RouterHelper. Currently even the symfony documentation doesn't use constants (which would suck in templates), but the real values: http://symfony.com/doc/current/book/templating.html#linking-to-pagesSo if we keep PHP templates in symfony (ref. #12897), we should IMO also deprecate the
generatemethod of the helper and instead addpathandurlmethods to the helper. This way php templates would be closer to twig equivalents and people would not be forced into using constants (or meaningless numeric values) in templates.The text was updated successfully, but these errors were encountered: