-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Form][Guesser] Symfony should guess a better field type for Doctrine 'array' type #1692
Comments
Symfony don't use Doctrine mapping to do the field guessing but validation constraints. Maybe |
Symfony uses both for the guessing |
@stof, right, sorry. guessing for collection with doctrine <?php
//...
53 //case 'array':
54 // return new TypeGuess('Collection', array(), Guess::HIGH_CONFIDENCE);
//... |
Can't get far enough in the history of the guesser to understand why it's commented, any information ? Moreover, why there is an uppercase C on Collection ? Is is because a long time ago types began with upercases ? |
Reading the history, this is commented since the first implementation of the guesser: 3bf9f77 |
@bschussek what was the reason to comment the guessing for the array fields ? |
@stof Simply that I didn't know what to do back then. What should we guess? "collection"? |
Task for the BHD: guess collection for both Doctrine arrays & |
Working on it right now |
Commits ------- 8bdff01 [DoctrineBridge][Form] added collection guess for array Doctrine type and array constraint type Discussion ---------- [Form] [DoctrineBridge] Better field type guessing for array doctrine type and array validator type Bug fix: no Feature addition: yes Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: #1692 Todo: - --------------------------------------------------------------------------- by bschussek at 2012-04-18T08:45:17Z Could you please add an entry to the CHANGELOG and squash your commits into one? --------------------------------------------------------------------------- by pvanliefland at 2012-04-18T17:20:39Z Done
Currently defaults to a textbox which just displays 'Array'.
The text was updated successfully, but these errors were encountered: