DomCrawler parents only on first node of selection

[flip111]

The DomCrawler seems to take the first node and traverse up the tree until the root node. But i think that the selection can have different parents, when i saw the function description i would expect it gets the parent of each node in the selection. So with 5 nodes selected i would get 5 parents, of which some could be the same parent (an array of 5 references of which some references to the same object). My suggestion would be to introduce another method with the functionality just described. About naming the methods i'm not sure yet.'

symfony/src/Symfony/Component/DomCrawler/Crawler.php

Lines 469 to 492 in b85ab60

	/**
	* Returns the parents nodes of the current selection.
	*
	* @return Crawler A Crawler instance with the parents nodes of the current selection
	*
	* @throws \InvalidArgumentException When current node is empty
	*/
	public function parents()
	{
	if (!$this->nodes) {
	throw new \InvalidArgumentException('The current node list is empty.');
	}
	$node = $this->getNode(0);
	$nodes = array();
	while ($node = $node->parentNode) {
	if (XML_ELEMENT_NODE === $node->nodeType) {
	$nodes[] = $node;
	}
	}
	return $this->createSubCrawler($nodes);
	}

[xabbuh]

All other methods only work on the first node of the current selection. Adding a method that would work with all nodes from the selection might be confusing.

So I am 👎 on this suggestion.

[flip111]

@xabbuh i did a quick count, seems that 13 of the 53 methods have getNode(0) in them. Also the responsibility or "category" of the methods seem to be varying quite a bit. Maybe better look at the use of the method then worrying about it being confusing related to other methods? That's what the API doc is for, no?

[xabbuh]

@flip111 Well, we can of course update docblocks if there are some which are not clear enough.

[jakzal]

Anything to do here since the related PR was rejected?

[flip111]

Accept or reject the issue on principle, we can think of implementation later.

[carsonbot]

Thank you for this suggestion.
There has not been a lot of activity here for a while. Would you still like to see this feature?

[carsonbot]

Hello? This issue is about to be closed if nobody replies.

[flip111]

.

[carsonbot]

Thank you for this suggestion.
There has not been a lot of activity here for a while. Would you still like to see this feature?

[carsonbot]

Just a quick reminder to make a comment on this. If I don't hear anything I'll close this.

[carsonbot]

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!