Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebProfilerBundle 3.1.7 depends on TwigBridge 3.1.7 or Twig 1.28 #20802

Closed
sbuzonas opened this issue Dec 6, 2016 · 0 comments
Closed

WebProfilerBundle 3.1.7 depends on TwigBridge 3.1.7 or Twig 1.28 #20802

sbuzonas opened this issue Dec 6, 2016 · 0 comments

Comments

@sbuzonas
Copy link

sbuzonas commented Dec 6, 2016

There was a commit symfony/web-profiler-bundle@f14fd5c that bumped the minimum requirement of twig/twig to 1.28. A non-functional set of packages can be installed as initially reported in composer/composer#5945.

The twig templates in symfony/web-profiler-bundle use the with tag introduced in twig/twig v1.28. This dependency is updated on symfony/twig-bridge v3.1.7, however the constraints for symfony/web-profiler-bundle v3.1.7 requires symfony/twig-bridge ~2.8|~3.0.

@xabbuh xabbuh added the Bug label Dec 8, 2016
fabpot added a commit that referenced this issue Dec 9, 2016
This PR was merged into the 2.7 branch.

Discussion
----------

[WebProfilerBundle] add dependency on Twig

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20802
| License       | MIT
| Doc PR        |

Requiring a specific minimum version of the TwigBridge just to be sure
that we end up with the required Twig version does not make much sense
if can simply specify the required version instead (we do in fact depend
on Twig in the WebProfilerBundle).

Commits
-------

91689a7 add dependency on Twig
@fabpot fabpot closed this as completed Dec 9, 2016
ostrolucky pushed a commit to ostrolucky/symfony that referenced this issue Mar 25, 2018
This PR was merged into the 2.7 branch.

Discussion
----------

[WebProfilerBundle] add dependency on Twig

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony#20802
| License       | MIT
| Doc PR        |

Requiring a specific minimum version of the TwigBridge just to be sure
that we end up with the required Twig version does not make much sense
if can simply specify the required version instead (we do in fact depend
on Twig in the WebProfilerBundle).

Commits
-------

91689a7 add dependency on Twig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants