[FrameworkBundle] Fix misresolved parameters in debug:config #20909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The patch proposed by fabbot is not related to this PR thus cannot be applied. |
|
|
||
| private static function resolveParametersValues(ContainerBuilder $builder, $configs) | ||
| { | ||
| return $builder->resolveEnvPlaceholders($builder->getParameterBag()->resolveValue($configs)); |
There was a problem hiding this comment.
Not sure about the need for this method
There was a problem hiding this comment.
I thought it could ease updating this command again after #20618, removed
|
Why that? I think we can apply it, wouldn't be the first time. |
chalasr
force-pushed
the
fix/debug-config-resolve-params
branch
3 times, most recently
from
5f1b505
to
1d17ae2
Compare
|
From our contributing guidelines:
Applied! :) |
|
👍 |
chalasr
force-pushed
the
fix/debug-config-resolve-params
branch
from
1d17ae2
to
c88bc89
Compare
chalasr
changed the title
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Dec 14, 2016
This PR was merged into the 3.2 branch. Discussion ---------- Fix misresolved parameters in debug:config on 3.2 | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This fixes parameters resolution (classic and env ones) in `debug:config`, again. Merging #20714 broke the fix resolving env parameters made in #20688, and anyway it was mismerged (#20714 was not applied when using the `path` argument, my bad, I should have prevented it). This adds a test which prevents regressions so I hope this is is the last PR on this subject. The buggy output is unfortunately part of the last 3.2 release... It can easily be confirmed by running `debug:config doctrine` on a fresh symfony-demo project Commits ------- c88bc89 Fix misresolved parameters in debug:config on 3.2
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes parameters resolution (classic and env ones) in
debug:config, again.Merging #20714 broke the fix resolving env parameters made in #20688, and anyway it was mismerged (#20714 was not applied when using the
pathargument, my bad, I should have prevented it).This adds a test which prevents regressions so I hope this is is the last PR on this subject.
The buggy output is unfortunately part of the last 3.2 release... It can easily be confirmed by running
debug:config doctrineon a fresh symfony-demo project