Request::getClientIp returns null when running in cli mode

[miklcct]

Q	A
Bug report?	yes
Feature request?	no
BC Break report?	no
RFC?	no
Symfony version	3.2.7

Running

(new Symfony\Component\HttpFoundation\Request)->getClientIp();

from cli gets null which violates the PHPDoc saying it return string.

[xabbuh]

While this is true what is the point in asking for the client IP on the CLI where there is no HTTP request at all?

[miklcct]

I discovered the bug when a middleware calling this was added into the application stack and called in unit tests, and failed unexpectedly by throwing TypeError because I passed the result directly into a string argument.

[xabbuh]

The only thing we can do is to relax the return type in the docblock as there is no IP address we could return. So that would not really solve your issue.

[miklcct]

If the return type is correct I would have already handled the null case accordingly, so please modify the doc to reflect the reality. Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Christian Flothmann <notifications@github.com> Sent: Thursday, April 13, 2017 6:07:39 PM To: symfony/symfony Cc: Michael Tsang; Author Subject: Re: [symfony/symfony] Request::getClientIp returns null when running in cli mode (#22415) The only thing we can do is to relax the return type in the docblock as there is no IP address we could return. So that would not really solve your issue. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#22415 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACskACITfifuQ1rl-Joc1x4DYtBqVYYSks5rvfPrgaJpZM4M8YX4>.