Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HttpFoundation] Fix getClientIp @return docblock #22418

Merged
merged 1 commit into from Apr 13, 2017
Merged

[HttpFoundation] Fix getClientIp @return docblock #22418

merged 1 commit into from Apr 13, 2017

Conversation

e-moe
Copy link
Contributor

@e-moe e-moe commented Apr 13, 2017

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22415
License MIT
Doc PR none

@e-moe e-moe force-pushed the ticket_22415 branch 2 times, most recently from 9bfbb08 to 6932072 Compare April 13, 2017 11:07
javiereguiluz
javiereguiluz approved these changes Apr 13, 2017
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@e-moe e-moe force-pushed the ticket_22415 branch 2 times, most recently from 27556c9 to 1fb44d3 Compare April 13, 2017 11:18
@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Apr 13, 2017
@fabpot
Copy link
Member

fabpot commented Apr 13, 2017

Thank you @e-moe.

@fabpot fabpot merged commit af3424f into symfony:2.7 Apr 13, 2017
fabpot added a commit that referenced this pull request Apr 13, 2017
@fabpot
minor #22418 [HttpFoundation] Fix getClientIp @return docblock (e-moe)
5742958 
This PR was merged into the 2.7 branch.

Discussion
----------

[HttpFoundation] Fix getClientIp @return docblock

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22415
| License       | MIT
| Doc PR        | none

Commits
-------

af3424f [HttpFoundation] Fix getClientIp @return docblock
@ossinkine
Copy link
Contributor

IMO the client IP can not be null in HTTP request. If you mock a request to use it in tests (as @miklcct described in #22415), you should make it correctly.
I suggest to revert this PR.

@ossinkine
Copy link
Contributor

ossinkine commented Jul 19, 2019 •
edited

Moreover, it is impossible even runtime: you'll get a notice Undefined offset: 0 if $ipAddresses[0] is undefined.

@ossinkine ossinkine mentioned this pull request Jul 23, 2019
Merged
fabpot added a commit that referenced this pull request Aug 4, 2019
@fabpot
bug #32682 [HttpFoundation] Revert getClientIp @return docblock (ossi…
2b0f2de 
…nkine)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpFoundation] Revert getClientIp @return docblock

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

This PR reverts #22418, see the comment #22418 (comment)

Commits
-------

7568d34 [HttpFoundation] Revert getClientIp @return docblock
symfony-splitter pushed a commit to symfony/http-foundation that referenced this pull request Aug 4, 2019
@fabpot
bug #32682 [HttpFoundation] Revert getClientIp @return docblock (ossi…
6e2b0a9 
…nkine)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpFoundation] Revert getClientIp @return docblock

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

This PR reverts symfony/symfony#22418, see the comment symfony/symfony#22418 (comment)

Commits
-------

7568d3452d [HttpFoundation] Revert getClientIp @return docblock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@sstok sstok sstok approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug HttpFoundation Status: Needs Review Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@e-moe @fabpot @ossinkine @javiereguiluz @sstok @xabbuh @nicolas-grekas @carsonbot