Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show current and default locales in web debug toolbar #23583

Closed
bocharsky-bw opened this issue Jul 19, 2017 · 2 comments
Closed

Show current and default locales in web debug toolbar #23583

bocharsky-bw opened this issue Jul 19, 2017 · 2 comments
Labels
Feature WebProfilerBundle

Comments

@bocharsky-bw
Copy link
Contributor

bocharsky-bw commented Jul 19, 2017 •
edited
Loading

Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? yes
Symfony version master

I think this information could be useful for debugging multi-lang apps. For now I need manually dump $request->getLocale()/$request->getDefaultLocale() in code to see it. We can show it in the Request tab:
screen shot 2017-07-19 at 11 28 19

UPD: Noticed _locale in "Request Attributes" section of profiler's Request panel though.
@xabbuh
Copy link
Member

xabbuh commented Jul 19, 2017

This could indeed be useful as part of the translation panel. The _locale request attribute does not necessarily have to be the same as the locale used by the translator.

@bocharsky-bw
Copy link
Contributor Author

As I see it in translation tab & panel:
screen shot 2017-07-19 at 23 29 32
screen shot 2017-07-19 at 23 29 47

nemoneph added a commit to nemoneph/symfony that referenced this issue Jul 22, 2017
@nemoneph
Feature symfony#23583 Add current and fallback locales in WDT / Profiler
5f1a700
@nemoneph nemoneph mentioned this issue Jul 22, 2017
Merged
nemoneph added a commit to nemoneph/symfony that referenced this issue Jul 22, 2017
@nemoneph
Feature symfony#23583 Add current and fallback locales in WDT / Profiler
f0e0ee9
nemoneph added a commit to nemoneph/symfony that referenced this issue Jul 24, 2017
@nemoneph
Feature symfony#23583 Add current and fallback locales in WDT / Profiler
3f7edd0
nemoneph added a commit to nemoneph/symfony that referenced this issue Jul 25, 2017
@nemoneph
Feature symfony#23583 Add current and fallback locales in WDT / Profiler
e425993
nemoneph added a commit to nemoneph/symfony that referenced this issue Jul 25, 2017
@nemoneph
Feature symfony#23583 Add current and fallback locales in WDT / Profiler
2ccab30
nemoneph added a commit to nemoneph/symfony that referenced this issue Jul 26, 2017
@nemoneph
Feature symfony#23583 Add current and fallback locales in WDT / Profiler
4b4ea3b
nemoneph added a commit to nemoneph/symfony that referenced this issue Sep 5, 2017
@nemoneph
Feature symfony#23583 Add current and fallback locales in WDT / Profiler
01ce8f0
nemoneph added a commit to nemoneph/symfony that referenced this issue Sep 11, 2017
@nemoneph
Feature symfony#23583 Add current and fallback locales in WDT / Profiler
98a8a6c
fabpot added a commit that referenced this issue Sep 13, 2017
@fabpot
feature #23625 Feature #23583 Add current and fallback locales in WDT…
30e3b6d 
… / Profiler (nemoneph)

This PR was merged into the 3.4 branch.

Discussion
----------

Feature #23583  Add current and fallback locales in WDT / Profiler

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      |  no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23583
| License       | MIT
| Doc PR        | -

The goal of this PR is to add informations about the locale and the fallback locales in the translation WDT panel / and profiler

Commits
-------

98a8a6c Feature #23583  Add current and fallback locales in WDT / Profiler
@fabpot fabpot closed this as completed Sep 13, 2017
fabpot added a commit that referenced this issue Sep 15, 2017
@fabpot
Merge branch '3.4'
b05fce2 
* 3.4:
  A DI tag for resettable services.
  Add default templates directory and option to configure it
  Feature #23583  Add current and fallback locales in WDT / Profiler
This was referenced Oct 18, 2017
Merged
Merged
ostrolucky pushed a commit to ostrolucky/symfony that referenced this issue Mar 25, 2018
@nemoneph
Feature symfony#23583 Add current and fallback locales in WDT / Profiler
cb3e2b8
ostrolucky pushed a commit to ostrolucky/symfony that referenced this issue Mar 25, 2018
@fabpot
feature symfony#23625 Feature symfony#23583 Add current and fallback …
c52b579 
…locales in WDT / Profiler (nemoneph)

This PR was merged into the 3.4 branch.

Discussion
----------

Feature symfony#23583  Add current and fallback locales in WDT / Profiler

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      |  no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony#23583
| License       | MIT
| Doc PR        | -

The goal of this PR is to add informations about the locale and the fallback locales in the translation WDT panel / and profiler

Commits
-------

98a8a6c Feature symfony#23583  Add current and fallback locales in WDT / Profiler
ostrolucky pushed a commit to ostrolucky/symfony that referenced this issue Mar 25, 2018
@fabpot
Merge branch '3.4'
9d25f73 
* 3.4:
  A DI tag for resettable services.
  Add default templates directory and option to configure it
  Feature symfony#23583  Add current and fallback locales in WDT / Profiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature WebProfilerBundle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @xabbuh @bocharsky-bw