Runnable query is not runnable in DoctrineDataCollector

[garak]

Q	A
Bug report?	yes
Feature request?	no
BC Break report?	no
RFC?	no
Symfony version	3.3

This is some kind of re-opening of #20673.
The implementations done in 3b4a8f3 missed the point.
Getting a runnable query like the following one:

SELECT s0_.name AS name_0 FROM slide s0_ WHERE s0_.id = 'Object(Ramsey\\Uuid\\Uuid): \"363dd322-488e-4a60-8caf-c3cfe51f9d7c\"' LIMIT 1;

is pretty useless, because it's obviously not runnable at all.
What I expect is a query like this one:

SELECT s0_.name AS name_0 FROM slide s0_ WHERE s0_.id = '363dd322-488e-4a60-8caf-c3cfe51f9d7c' LIMIT 1;

that is really runnable (e.g. I can copy&paste in some database client)

[xabbuh]

Related to (or duplicate of) #24700?

[garak]

It's not a duplicate, this case is more general, i.e. it can apply to every time an object is used in a query (not only to an entity used as identifier).

[Simperfit]

Since this has been labeled as a bug, @garak can you work on it ?

[kix]

What could be done here is making the DoctrineDataCollector::sanitizeParam return the Object(%s): part commented out so that the output would be like:

SELECT s0_.name AS name_0 FROM slide s0_ WHERE s0_.id = /* Object(Ramsey\\Uuid\\Uuid): */ "363dd322-488e-4a60-8caf-c3cfe51f9d7c" LIMIT 1;

Although I think actually the problem is that parameters are replaced inside the query and not in a separate procedure, e.g. to get a runnable query, we just modify the one we have and fill in the placeholders with values. In my opinion, the runnable query should be a separate entity perhaps.

[garak]

Unfortunately, this bug is still present in Symfony 4.4
This is an output example of runnable query:

SELECT u0_.email AS email_0, u0_.password AS password_1, u0_.id AS id_6 FROM user_ u0_ WHERE u0_.id = '/* Object(Ramsey\Uuid\Uuid): */"c91dd2d6-ba8e-11e8-bdaf-0242ac1d0003"' LIMIT 1;

as you can see, the query is not runnable at all, since the whole string (with the comment) is single-quoted, while the double-quoted uuid is escaped 😔