Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebProfilerBundle] Incomplete dark themed components #29194

Closed
ro0NL opened this issue Nov 12, 2018 · 8 comments
Closed

[WebProfilerBundle] Incomplete dark themed components #29194

ro0NL opened this issue Nov 12, 2018 · 8 comments
Assignees
@javiereguiluz
Labels
WebProfilerBundle

Comments

@ro0NL
Copy link
Contributor

ro0NL commented Nov 12, 2018 •
edited

Symfony version(s) affected: 4.2

image

the active menu and toggles icon are a bit incompatible still.
@ro0NL
Copy link
Contributor Author

ro0NL commented Nov 12, 2018

Twig

image

@ro0NL ro0NL changed the title [WebProfilerBundle] Dark theme for forms incomplete [WebProfilerBundle] Incomplete dark themed components Nov 12, 2018
@ro0NL
Copy link
Contributor Author

ro0NL commented Nov 12, 2018 •
edited

More problematic perhaps; Exception

image

on the traces tab i think the titles are too dark..

image

@ro0NL
Copy link
Contributor Author

ro0NL commented Nov 12, 2018

Messages

image

@ro0NL
Copy link
Contributor Author

ro0NL commented Nov 12, 2018

Validator

image

@ro0NL
Copy link
Contributor Author

ro0NL commented Nov 12, 2018 •
edited

Logs (i think the borders are off)

image

@javiereguiluz javiereguiluz self-assigned this Nov 18, 2018
@ro0NL
Copy link
Contributor Author

ro0NL commented Nov 25, 2018

Time

image

@ro0NL
Copy link
Contributor Author

ro0NL commented Dec 4, 2018

Debug

image

@ro0NL ro0NL mentioned this issue Dec 9, 2018
Closed
@lmlsna
Copy link

lmlsna commented Jan 4, 2019

Also the .word and .symbol classes in use on the Doctrine tab are set to #222 even when the .theme-dark is applied.

@dFayet dFayet mentioned this issue Apr 4, 2019
Merged
@fabpot fabpot closed this as completed Apr 6, 2019
fabpot added a commit that referenced this issue Apr 6, 2019
@fabpot
bug #30860 [Profiler] Fix dark theme elements color (dFayet)
07a1095 
This PR was squashed before being merged into the 4.2 branch (closes #30860).

Discussion
----------

[Profiler] Fix dark theme elements color

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #29194   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | -

I think the color handling of the code highlighted (exceptions, ...) is quite questionnable, but as we use the `highlight_file()` function, I don't really see an other way to handle it, tell me what you think.

###  Before/After
**Form**
![Capture d’écran de 2019-04-04 10-07-18](https://user-images.githubusercontent.com/7721219/55539945-2cfe0580-56c2-11e9-8e5c-a4b6352ab12d.png)

![Capture d’écran de 2019-04-04 10-03-27](https://user-images.githubusercontent.com/7721219/55539906-15268180-56c2-11e9-90e7-326cc1c01ccd.png)

**Twig render graph**
![Capture d’écran de 2019-04-04 10-07-36](https://user-images.githubusercontent.com/7721219/55539969-3b4c2180-56c2-11e9-9064-1fd10bf1da02.png)

![Capture d’écran de 2019-04-06 19-37-02](https://user-images.githubusercontent.com/7721219/55673094-693c8c00-58a3-11e9-90a4-76f6b312d516.png)

**Exceptions**
![Capture d’écran de 2019-04-04 10-08-19](https://user-images.githubusercontent.com/7721219/55540012-51f27880-56c2-11e9-930b-98d680093e49.png)

![Capture d’écran de 2019-04-06 09-39-27](https://user-images.githubusercontent.com/7721219/55667421-4f2b8b00-585c-11e9-81c7-dc09bd982375.png)

**Doctrine queries**
![Capture d’écran de 2019-04-04 10-08-37](https://user-images.githubusercontent.com/7721219/55540059-73536480-56c2-11e9-9b0d-ea691a16a1a5.png)

![Capture d’écran de 2019-04-04 10-04-47](https://user-images.githubusercontent.com/7721219/55540068-78b0af00-56c2-11e9-88f7-2181800006a7.png)

Commits
-------

8a9c2c8 [Profiler] Fix dark theme elements color
@ro0NL ro0NL mentioned this issue Apr 8, 2019
Merged
fabpot added a commit that referenced this issue Apr 8, 2019
@fabpot
bug #30999 Fix dark themed componnents (ro0NL)
0d786d3 
This PR was merged into the 4.2 branch.

Discussion
----------

Fix dark themed componnents

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | yes/no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Small follow up of #30860

![image](https://user-images.githubusercontent.com/1047696/55705391-f5070300-59de-11e9-8d7e-195ea74d17c3.png)

see #29194 (comment)
___

![image](https://user-images.githubusercontent.com/1047696/55705263-b40eee80-59de-11e9-9503-ba4adf64857c.png)

see #29194 (comment)

Commits
-------

d2f2e56 Fix dark themed componnents
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javiereguiluz javiereguiluz

Labels
WebProfilerBundle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fabpot @javiereguiluz @ro0NL @xabbuh @lmlsna