Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark themed componnents #30999

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Fix dark themed componnents #30999

merged 1 commit into from
Apr 8, 2019

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Apr 8, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? yes/no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

Small follow up of #30860

image

see #29194 (comment)


image

see #29194 (comment)

@fabpot
Copy link
Member

fabpot commented Apr 8, 2019

Thank you @ro0NL.

@fabpot fabpot merged commit d2f2e56 into symfony:4.2 Apr 8, 2019
fabpot added a commit that referenced this pull request Apr 8, 2019
This PR was merged into the 4.2 branch.

Discussion
----------

Fix dark themed componnents

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | yes/no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Small follow up of #30860

![image](https://user-images.githubusercontent.com/1047696/55705391-f5070300-59de-11e9-8d7e-195ea74d17c3.png)

see #29194 (comment)
___

![image](https://user-images.githubusercontent.com/1047696/55705263-b40eee80-59de-11e9-9503-ba4adf64857c.png)

see #29194 (comment)

Commits
-------

d2f2e56 Fix dark themed componnents
@ro0NL ro0NL deleted the dark branch April 8, 2019 07:40
@fabpot fabpot mentioned this pull request Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants