Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing translations for Slovak (sk) #41081

Closed
Nyholm opened this issue May 3, 2021 · 1 comment
Closed

Missing translations for Slovak (sk) #41081

Nyholm opened this issue May 3, 2021 · 1 comment
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Help wanted Issues and PRs which are looking for volunteers to complete them. Missing translations

Comments

@Nyholm
Copy link
Member

Nyholm commented May 3, 2021 •
edited by carsonbot
Loading

Hello,

There are some missing translation for Slovak (sk). These should be added in branch 4.4.
See #38710 for details and this page for an example.

These are the files that should be updated:

NOTE: If you want to work on this issue, add a comment to assign it to yourself and let others know that this is already taken.
@Nyholm Nyholm added Good first issue Ideal for your first contribution! (some Symfony experience may be required) Help wanted Issues and PRs which are looking for volunteers to complete them. Missing translations labels May 3, 2021
@bhavin-nakrani
Copy link
Contributor

I am working on this issue

@bhavin-nakrani bhavin-nakrani mentioned this issue Sep 20, 2021
Merged
fabpot pushed a commit to bhavin-nakrani/symfony that referenced this issue Sep 20, 2021
@bhavin-nakrani @fabpot
Add Slovak lang translation symfony#41081
5912608
fabpot added a commit that referenced this issue Sep 20, 2021
@fabpot
minor #43111 Add Slovak lang translation #41081 (bhavin-nakrani)
ffa3316 
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

Add Slovak lang translation #41081

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #41081 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

There are some missing translation for Slovak (sk). There are added in this PR.
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch 5.x.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
-->

Commits
-------

5912608 Add Slovak lang translation #41081
@fabpot fabpot closed this as completed Sep 20, 2021
derrabus added a commit that referenced this issue Sep 21, 2021
@derrabus
Merge branch '4.4' into 5.3
6ac6219 
* 4.4:
  Fix iterrator in ServiceConfigurator
  Add Slovak lang translation #41081
  [Validator] Add missing thai translation
  [Translation] Add Burmese translation
  [FrameworkBundle] Remove translation data_collector BEFORE adding it to profiler
derrabus added a commit that referenced this issue Sep 21, 2021
@derrabus
Merge branch '5.3' into 5.4
4d7501e 
* 5.3:
  Fix iterrator in ServiceConfigurator
  Add Slovak lang translation #41081
  [Validator] Add missing thai translation
  [Translation] Add Burmese translation
  [Notifier] Update FirebaseTransport.php
  [FrameworkBundle] Remove translation data_collector BEFORE adding it to profiler
derrabus added a commit that referenced this issue Sep 21, 2021
@derrabus
Merge branch '5.4' into 6.0
0895c36 
* 5.4:
  [Serializer] Save missing arguments in MissingConstructorArgumentsException
  remove support for deprecated "threadKey" parameter
  Remove useless comment in test
  [DomCrawler] Added Crawler::innerText() method
  [Form] Add the EnumType
  Fix iterrator in ServiceConfigurator
  [Console] Add support of RGB functional notation for output colors
  Add Slovak lang translation #41081
  [Validator] Add error's uid to `Count` and `Length` constraints with "exactly" option enabled
  [Validator] Add missing thai translation
  [Yaml] Add 0 to float repr
  [Translation] Add Burmese translation
  [Notifier] Update FirebaseTransport.php
  fix: #43086 remove shortcut e for option exclude of Yaml/LintCommand - solve conflict with --env -e
  Map `multipart/form-data` as `form` Content-Type
  [Serializer] Throw NotNormalizableValueException when type is not known or not in body in discriminator map
  [Yaml] Use more concise float representation in dump
  [FrameworkBundle] Remove translation data_collector BEFORE adding it to profiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Help wanted Issues and PRs which are looking for volunteers to complete them. Missing translations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @Nyholm @bhavin-nakrani