Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing translations for Chinese (zh_TW) #41815

Closed
carsonbot opened this issue Jun 24, 2021 · 4 comments
Closed

Missing translations for Chinese (zh_TW) #41815

carsonbot opened this issue Jun 24, 2021 · 4 comments
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Help wanted Issues and PRs which are looking for volunteers to complete them. Missing translations

Comments

@carsonbot
Copy link

Hello,

There are some missing translation for Chinese (zh_TW). These should be added in branch 4.4.
See #38710 for details and this page for an example.

These are the files that should be updated:

NOTE: If you want to work on this issue, add a comment to assign it to yourself and let others know that this is already taken.
@carsonbot carsonbot added Good first issue Ideal for your first contribution! (some Symfony experience may be required) Help wanted Issues and PRs which are looking for volunteers to complete them. Missing translations labels Jun 24, 2021
@fd6130
Copy link
Contributor

fd6130 commented Sep 23, 2021

I will work on this.

@fd6130
Copy link
Contributor

fd6130 commented Sep 23, 2021 •
edited
Loading

Seems like it is up to date. I didn't see any missing translate in branch 4.4 for zh_TW.

@fabpot
Copy link
Member

fabpot commented Oct 4, 2021

There is one missing entry for id 100. Have a look at src/Symfony/Component/Validator/Resources/translations/validators.en.xlf to find the English version and add it in src/Symfony/Component/Validator/Resources/translations/validators.zh_TW.xlf (in the 4.4 branch).

@fd6130 fd6130 mentioned this issue Oct 4, 2021
Merged
@fd6130
Copy link
Contributor

fd6130 commented Oct 4, 2021

There is one missing entry for id 100. Have a look at src/Symfony/Component/Validator/Resources/translations/validators.en.xlf to find the English version and add it in src/Symfony/Component/Validator/Resources/translations/validators.zh_TW.xlf (in the 4.4 branch).

Thx for reminding me about this issue. I just forgot to update my fork that's why i see no update in between those translations.

fabpot added a commit that referenced this issue Oct 4, 2021
@fabpot
minor #43303 Add zh_TW translation for #41815 (fd6130)
adeae1a 
This PR was merged into the 4.4 branch.

Discussion
----------

Add zh_TW translation for #41815

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #41815  <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | no <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch 5.x.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
-->

Commits
-------

19c610a add translation for zh_TW
@fabpot fabpot closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Help wanted Issues and PRs which are looking for volunteers to complete them. Missing translations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @fd6130 @carsonbot