Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AssetMapper] Remove unused method / BC break ? #54123

Closed
smnandre opened this issue Mar 1, 2024 · 1 comment · Fixed by #54125
Closed

[AssetMapper] Remove unused method / BC break ? #54123

smnandre opened this issue Mar 1, 2024 · 1 comment · Fixed by #54125
Labels
AssetMapper Bug Status: Needs Review

Comments

@smnandre
Copy link
Contributor

smnandre commented Mar 1, 2024

Symfony version(s) affected

7.0

Description

This method (ImportMapConfigReader::splitPackageNameAndFilePath) is unused, is it OK to delete it or is it covered by BC ?

(i do believe it stayed here by accident)

How to reproduce

The method has been moved to https://github.com/symfony/symfony/blob/7.0/src/Symfony/Component/AssetMapper/ImportMap/ImportMapEntry.php#L69

Possible Solution

No response

Additional Context

No response
@smnandre smnandre added the Bug label Mar 1, 2024
@fabpot
Copy link
Member

fabpot commented Mar 1, 2024

Unfortunately, it would be considered a BC break :(
Let's deprecate it so that we can at least remove it in 8.0.

@smnandre smnandre mentioned this issue Mar 1, 2024
Merged
@fabpot fabpot closed this as completed Mar 2, 2024
fabpot added a commit that referenced this issue Mar 2, 2024
@fabpot
feature #54125 [AssetMapper] Deprecate unused method `splitPackageNam…
31a9b35 
…eAndFilePath` (smnandre)

This PR was squashed before being merged into the 7.1 branch.

Discussion
----------

[AssetMapper] Deprecate unused method `splitPackageNameAndFilePath`

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | yes
| Issues        | Fix #54123
| License       | MIT

This method is not used in the codebase, and duplicates` ImportMapEntry::splitPackageNameAndFilePath()`

Commits
-------

9af1f34 [AssetMapper] Deprecate unused method `splitPackageNameAndFilePath`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
AssetMapper Bug Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AssetMapper] Deprecate unused method splitPackageNameAndFilePath smnandre/symfony
3 participants
@fabpot @smnandre @carsonbot