Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AssetMapper] Deprecate unused method splitPackageNameAndFilePath #54125

Merged

Conversation

smnandre
Copy link
Contributor

@smnandre smnandre commented Mar 1, 2024

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? yes
Issues Fix #54123
License MIT

This method is not used in the codebase, and duplicates ImportMapEntry::splitPackageNameAndFilePath()

@carsonbot carsonbot added this to the 7.1 milestone Mar 1, 2024
@smnandre smnandre changed the title [AssetMapper] Deprecate unused splitPackageNameAndFilePath [AssetMapper] Deprecate unused method splitPackageNameAndFilePath Mar 1, 2024
@fabpot
Copy link
Member

fabpot commented Mar 2, 2024

Thank you @smnandre.

@fabpot fabpot force-pushed the feat/im-config-deprecate-unused-method branch from 1cfe4fa to 9af1f34 Compare March 2, 2024 13:03
@fabpot fabpot merged commit 31a9b35 into symfony:7.1 Mar 2, 2024
1 check was pending
@fabpot fabpot mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AssetMapper] Remove unused method / BC break ?
6 participants