[Form] Binding a request with a missing file causes an exception instead of an invalid form

[roverwolf]

When a form that requires a file field is bound and the file is missing an exception is raised instead of just having $form->isValid() return false. If the file is not missing then things work well.

Warning: Missing argument 1 for Symfony\Component\HttpFoundation\File\File::__construct(), called in .../Symfony/Component/Form/Extension/Core/Type/FormType.php on line 172

A workaround is to wrap the $form->bind($this->getRequest()) in a try-catch block and then check if $form->isBound().

[Tobion]

I confirm this issue.

[andreadelfino]

This behaviour happened on my application after SF v2.1.3 -> v2.1.4 update, I think due 2fe04e1 changes.
I solved temporally setting data_class to null in form builders, but I don't like this solution... any better idea?

Es:

$builder->add('file', 'file', array('data_class' => null));

[dchaffin]

@andreadelfino ... I put in the 'data_class' setting you (reluctantly) suggested, but now my NotNull validation is not firing on my file field. It just blows right past it and submits the form. Have you found a better fix for this yet?

Thanks!

[dchaffin]

@andreadelfino ... Nevermind. I just realized I had commented out my NotNull constraint while testing.

[Tobion]

@bschussek can you please have a look. this makes upload forms kinda useless.
The exception is also thrown, if the uploaded file is too big. Normally an error should be assigned to the field.

[ghost]

Since this update, I've got a 500 error instead of validation failure when I try to post a form without a required file.

[webmozart]

Confirmed.

[diphda]

I have the same issue, with the last version. It will be fixed?

[webmozart]

Fixed in the referenced PR.

[diphda]

Thanks!
On Thu, 13 Dec 2012 05:35:49 -0800
Bernhard Schussek notifications@github.com wrote:

Fixed in the referenced PR.

---

Reply to this email directly or view it on GitHub:
#6134 (comment)

[ghost]

Thanks 👍 !