[2.1] Load translations by common way (using FilesLocator)

[Koc]

Now paths to files with translations adds when container compiles https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L407 . Sometimes needed change way to locate translation file, for example when there are themes, wich can override translations from bundle.

[skydiablo]

hiho!
some cognitions ?

[vicb]

@Koc currently we load from (highest priority first):

1. app/Resources/translations
2. app/Resources/<bundle>/translations
3. bundle\Resources\translations

To me 1 and 2 are equivalent (i.e. you should use one or the other but no make use of the different priorities they have - app is your code).

So the remaining question is where to look for other transaltions: before or after 3 (or should it be configurable) ?

[Koc]

Imho translations from theme should have possibility override all other translations.

Edit: I've tangled with priorities %).

[vicb]

@Koc could you provide more details on your use case ? Wouldn't your theme be a bundle ?

[Koc]

If it would be a bundle we should register it after all other bundles for overridion translations. But there is other situation: 2 themes with different translations (after compilation we got compiled translations only for one theme).

It looks harder than I've thinked,

[jakzal]

@Koc is it a real life use case for two themes with different translations?

[sstok]

I do have one use, I have a component which provides some translations.
But there is no way to get them in the bundle with duplicating them, or (as I'm currently doing) using a hack. https://github.com/rollerworks/RollerworksSearchBundle/blob/master/src/Rollerworks/Bundle/SearchBundle/DependencyInjection/Compiler/TranslatorPass.php

I did came up with a "better" solution, which to use the Filesystem::mirror() for copying the translations files using Bundle::boot() but its still a hack.

For themes I'd rather use custom Translator, which falls back to the default when there is no translations available. Mainly because a theme can change at any time, and you'd don't want perform the cache warming again :)