[Form] Separate errors and display errors

[webmozart]

I would like to separate errors and "display errors" in the form component. Therefore I would like to add two methods to FormInterface:

public function getDisplayErrors($deep = false, $flatten = true);

public function addDisplayError(FormError $error);

The idea is that getDisplayErrors() should return the errors that should be displayed on a given form, while getErrors() should only return the errors that were actually caused by the field. In this way, it will be possible to distinguish really erroneous fields from those that only display errors of other fields (#6001).

To make that work, I would like to deprecate the "error_bubbling" option and introduce an equivalent option for the addDisplayError() method. The option should control the following:

• either errors are displayed at the field they are created on (the default)
• or they are displayed on the containing form

What should we call this option? "display_errors"?

$builder->add('field', 'type', array(
    // show errors on the field
    'display_errors' => true,
    // show errors on the form
    'display_errors' => false,
));

Unfortuantely we cannot continue to use "error_bubbling", because then we need to break BC.

[willdurand]

"errors_level":

$builder->add('field', 'type', array(
    // show errors on the field
    'errors_level' => 'field',
    // show errors on the form
    'errors_level' => 'form',
));

"inline_errors":

$builder->add('field', 'type', array(
    // show errors on the field
    'inline_errors' => true,
    // show errors on the form
    'inline_errors' => false,
));

[stof]

field vs form is weird IMO, as everything is a Form in Symfony. It should be root to talk about the root form to be consistent

[webmozart]

Which leads me to an alternative proposal:

$builder->add('field', 'type', array(
    // show errors on the field
    'display_errors' => 'self',
    // show errors on the parent form
    'display_errors' => 'parent',
    // show errors on the root form
    'display_errors' => 'root',
));

[willdurand]

display_errors makes me think about the PHP setting, and so I would except to set either true or false. It is more a matter of "level" IMHO.

[stof]

maybe error_location or error_position ?

[willdurand]

@stof what's the difference between your two proposals?

[stof]

sorry, edited it to actually give the 2 proposal I thought about

[nicolopignatelli]

what about display_errors_on or just errors_on with self, parent and root as options as proposed by @bschussek ?

Alternatively, error_location sounds clear enough for me, as well.

[Tobion]

So when you would want to show errors two levels higher in hierarchy, you would set error_location of the field to parent and in the parent form you set the option to parent as well. Right?

I think the new option with parent|self|root makes more sense than the old error_bubbling because it is more user-centric whereas error_bubbling was just technical.

[webda2l]

+1 for second Bernhard proposition #9994 (comment)
And errors_scope as other possible alternative

[stanlemon]

This would be a great change! I like error_scope too fwiw.

[emgiezet]

👍 for the parent|self|root

[raziel057]

+1 for errors_scope or display_errors_scope with possible values self | parent | root.

[mdavis1982]

@webmozart Have there been any updates on this?

[SofHad]

👍 for error_location with self | parent | root

[mfrieswyk]

@webmozart status bump? Is this issue still relevant or stale?

[ThomasLandauer]

If the value would be an array, you could choose multiple error locations:

error_location => ['self','parent']

See #36729

[carsonbot]

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

[xabbuh]

Let's close this old issue as nobody cared enough to implement this feature.