[Security] Added AbstractExceptionListener #11103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to use a custom implementations of exception listeners.
| */ | ||
| public function add(RequestMatcherInterface $requestMatcher = null, array $listeners = array(), ExceptionListener $exceptionListener = null) | ||
| public function add( |
There was a problem hiding this comment.
please keep method declaration on a single line
|
Will this get merged? |
| use Symfony\Component\HttpKernel\KernelEvents; | ||
|
|
||
| /** | ||
| * Interface that must be implemented by firewall exception listener |
There was a problem hiding this comment.
This is an abstract class, not an interface.
|
I'm 👎 on this one. The logic in the exception listener is quite complex and I fail to see how you would reimplement something different but still compatible with the default one. So, that's not an extension point I want to expose to the users. But of course, you can still just extend the existing class and implement your logic. |
|
I want to send |
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use a custom implementations of exception listeners.