[2.3][Form] Check if IntlDateFormatter constructor returned a valid object before using it #11334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parent constructor will create a new formatter if the $formatter parameter is null This fix avoids that the formatter becomes 2 different instances in $this and $this->stderr
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes symfony#11272). Discussion ---------- [Console] Make sure formatter is the same. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The parent constructor will create a new formatter if the $formatter parameter is null. This fix avoids that the formatter becomes 2 different instances in $this and $this->stderr, if null was passed to the constructor. Commits ------- 64328d9 [Console] Make sure formatter is the same
There is no reason to turn a failure into a different failure. And this will avoid Travis to say that the "false" command failed.
… of the uri of a link (benja-M-1) This PR was squashed before being merged into the 2.3 branch (closes symfony#11194). Discussion ---------- [DomCrawler] Remove the query string and the anchor of the uri of a link | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- fe5d2d1 [DomCrawler] Remove the query string and the anchor of the uri of a link
…akzal) This PR was merged into the 2.3 branch. Discussion ---------- [DomCrawler] Fix Link docblocks and formatting | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - re symfony#11194 Commits ------- 5cbe13e [DomCrawler] Fix docblocks and formatting.
…orselli) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes symfony#11246). Discussion ---------- [Validator] updated italian translations Commits ------- b74afe0 updated italian translation for validation messages
…er (JustBlackBird) This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes symfony#11238). Discussion ---------- [Translation] Added unescaping of ids in PoFileLoader | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Although it is not directly described in gettext docs, _msgid_ should be unescaped too. The other reason to unescape _msgid_ is symmetry between ```PoFileLoader``` and ```PoFileDumper```. The dumper escapes both _msgid_ and _msgstr_ values, but the loader unescapes only _msgstr_. Commits ------- 816a4a9 [Translation] Added unescaping of ids in PoFileLoader
This PR was merged into the 2.3 branch. Discussion ---------- Simplified the Travis test command There is no reason to turn a failure into a different failure. And this will avoid Travis to say that the "false" command failed. Commits ------- e8d01c9 Simplified the Travis test command
|
Isn't something we need to do in 2.3? |
|
woops, you're right, I thought I proposed this change in 2.3 and I targeted the wrong branch here. Let me close this one and reopen a new one. I think merging this with gh in 2.3 would not be so easy |
|
I've updated my branch, you should now be able to merge it in 2.3 easily |
fabpot
added a commit
that referenced
this pull request
Jul 23, 2014
…d a valid object before using it (romainneutron) This PR was merged into the 2.3 branch. Discussion ---------- [2.3][Form] Check if IntlDateFormatter constructor returned a valid object before using it | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT `IntlDateFormatter` constructor [may return false](http://www.php.net/manual/en/intldateformatter.create.php#refsect1-intldateformatter.create-returnvalues). This patches avoids fatal errors in these cases This PR replaces #11334 Commits ------- ebf967d [Form] Check if IntlDateFormatter constructor returned a valid object before using it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntlDateFormatterconstructor may return false. This patches avoids fatal errors in these cases