Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Removed legacy validator classes #11587

Merged
merged 1 commit into from Aug 7, 2014

Conversation

webmozart
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This PR removes the legacy validator classes again and adds the API checks inside the constraint validators instead.

@stof
Copy link
Member

stof commented Aug 6, 2014

👍 this is easier to maintain, and it shows how bundle would have to do to support both APIs too (they cannot register their own constraints in the legacy factory)

@fabpot
Copy link
Member

fabpot commented Aug 7, 2014

👍

@fabpot
Copy link
Member

fabpot commented Aug 7, 2014

Thank you @webmozart.

@fabpot fabpot merged commit e844ed0 into symfony:2.5 Aug 7, 2014
fabpot added a commit that referenced this pull request Aug 7, 2014
This PR was merged into the 2.5 branch.

Discussion
----------

[Validator] Removed legacy validator classes

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This PR removes the legacy validator classes again and adds the API checks inside the constraint validators instead.

Commits
-------

e844ed0 [Validator] Removed legacy validator classes
@webmozart webmozart deleted the remove-legacy-validators branch August 15, 2014 09:43
bobdenotter added a commit to bolt/bolt that referenced this pull request Aug 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants