[DomCrawler] fixed bug #12143 #12283
Conversation
dkop
commented
Oct 22, 2014
dkop
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #12143 |
| License | MIT |
| Doc PR | - |
| @@ -176,13 +182,13 @@ public function addHtmlContent($content, $charset = 'UTF-8') | |||
|
|
|||
| $baseHref = current($base); | |||
| if (count($base) && !empty($baseHref)) { | |||
| if ($this->uri) { | |||
| if ($this->baseHref) { | |||
There was a problem hiding this comment.
Can this ever be false given that it was not empty?
There was a problem hiding this comment.
On line 184 $baseHref, on line 185 $this->baseHref
|
This replaces #12144, could you please add the tests from that PR here? Btw, many thanks for working on this one! I really hope this is merged soon, as it's one of the blockers for my company to start using Behat... |
|
@dkop it is wrong for This is actually what the DomCrawler is doing wrong, resulting in failed tests for me. |
|
@dkop Will you have time to finish this one? It looks like that we are almost there. |
|
@fabpot as i can understand it is already done. array('http://base.com' /* base */, '' /* href */, 'http://base.com' /* expectedUri */, 'http://domain.com/path/link', '<base> tag does work with empty links'),This line of tests is correct right now according to the test in browsers: http://jsbin.com/laxugelire/2/quiet |
|
@dkop it is incorrect for links, but correct for form. Atm, the form inherits all url logic from link. You should change Form class to use the special form logic. |
|
closing in favor of #13145 |
This PR was merged into the 2.3 branch. Discussion ---------- [DomCrawler] Fix behaviour with <base> tag Finishes #12283 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12283, #12143, #12144 | License | MIT | Doc PR | - Commits ------- 91447e8 Make fabbot happy 1d35e48 Clean up testing 61f22d7 [DomCrawler] fixed bug #12143
This PR was merged into the 2.3 branch. Discussion ---------- [DomCrawler] Fix behaviour with <base> tag Finishes symfony/symfony#12283 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12283, #12143, #12144 | License | MIT | Doc PR | - Commits ------- 91447e8 Make fabbot happy 1d35e48 Clean up testing 61f22d7 [DomCrawler] fixed bug #12143
