[DomCrawler] Fix behaviour with <base> tag #13145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 29, 2014
|
Thank you @wouterj. |
fabpot
added a commit
that referenced
this pull request
Dec 29, 2014
This PR was merged into the 2.3 branch. Discussion ---------- [DomCrawler] Fix behaviour with <base> tag Finishes #12283 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12283, #12143, #12144 | License | MIT | Doc PR | - Commits ------- 91447e8 Make fabbot happy 1d35e48 Clean up testing 61f22d7 [DomCrawler] fixed bug #12143
fabpot
added a commit
that referenced
this pull request
Sep 14, 2015
…esent (danez) This PR was squashed before being merged into the 2.3 branch (closes #13794). Discussion ---------- [DomCrawler] Invalid uri created from forms if base tag present | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Since #13145 was merged the provided testcase does not work anymore and creates an invalid link This affects the latest versions of 2.3, 2.5, 2.6 and 2.7 Right now this PR only includes the failing test, as I could no easy find a fix. If someone immediately knows whats the problem, give me a hint please. Commits ------- dc57a7a [DomCrawler] Invalid uri created from forms if base tag present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes #12283