[Twig] autoescape_service option stops container from being dumped #13467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabpot Seems to fix the issue |
fabpot
added a commit
that referenced
this pull request
Jan 30, 2015
…it cannot contain service references) (fabpot) This PR was merged into the 2.7 branch. Discussion ---------- [TwigBundle] fixed Twig options (removed the parameter as it cannot contain service references) | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | #13467 | License | MIT | Doc PR | n/a The new `autoescape_service` option is used to set the `autoescape` Twig option, which can be a callable. The Twig options are stored in a parameter (`twig.options`), but as parameters cannot have references, that does not work well. So, this PR removed the parameter as it is not needed. Commits ------- 69748a1 [TwigBundle] fixed Twig options (removed the parameter as it cannot contain service references)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
twig.autoescape_serviceoption is set from then the container cannot be dumped.I haven't been able to nail down why this is the case, but I have added to the test to show this happening. In a symfony project this means this error is shown when trying to run the console: