[TwigBundle] fixed Twig options (removed the parameter as it cannot contain service references) #13476
Conversation
…ontain service references)
|
I've also made an additional commit to remove two other unneeded parameters. |
|
isn't it a BC break to remove these parameters (for edge cases though) ? |
|
|
||
| $container->setParameter('twig.form.resources', $config['form_themes']); |
There was a problem hiding this comment.
hmm, actually, I'm quite sure I know about bundles relying on this parameter to prepend form themes defining the rendering of their special blocks, so this is an actual BC break
fabpot
force-pushed
the
autoescape-fix
branch
from
5bbc788
to
69748a1
Compare
|
I've removed the second commit to keep BC |
|
👍 |
…it cannot contain service references) (fabpot) This PR was merged into the 2.7 branch. Discussion ---------- [TwigBundle] fixed Twig options (removed the parameter as it cannot contain service references) | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | #13467 | License | MIT | Doc PR | n/a The new `autoescape_service` option is used to set the `autoescape` Twig option, which can be a callable. The Twig options are stored in a parameter (`twig.options`), but as parameters cannot have references, that does not work well. So, this PR removed the parameter as it is not needed. Commits ------- 69748a1 [TwigBundle] fixed Twig options (removed the parameter as it cannot contain service references)
|
SonataCacheBundle was relying on this parameter. See sonata-project/SonataCacheBundle#72 |
|
@richardfullmer Can you please open a new issue if you think that this is a bug? |
|
I don't necessarily think it's a bug. How does one tell which parameters will have guaranteed BC verses those that don't? |
|
They are no guarantees on parameters except for the one defined in the kernel (like debug, ...). Almost all parameters are private and should not be relied on. |
|
thanks |
|
I stumbled around that issue as well as I used that to have a second twig environment with just a string loader for special renderings. I did not want to use the loader chain aas I wanted still errors in case of a wrong template name. A sample implementation can be found here: What is the easiest way to work around that now? |
The new
autoescape_serviceoption is used to set theautoescapeTwig option, which can be a callable. The Twig options are stored in a parameter (twig.options), but as parameters cannot have references, that does not work well.So, this PR removed the parameter as it is not needed.