[Form] [EventListener] fixed sending non array data on preSubmit to ResizeFormListener #13851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BruceWouaigne
commented
Mar 5, 2015
BruceWouaigne
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #13804 |
| License | MIT |
| Doc PR | - |
| @@ -145,7 +145,7 @@ public function onSubmit(FormEvent $event) | |||
| } | |||
|
|
|||
| if (!is_array($data) && !($data instanceof \Traversable && $data instanceof \ArrayAccess)) { | |||
| throw new UnexpectedTypeException($data, 'array or (\Traversable and \ArrayAccess)'); | |||
| $data = array(); | |||
There was a problem hiding this comment.
Shouldn't this be done in the preSubmit method instead ?
BruceWouaigne
force-pushed
the
ticket_13804
branch
from
d745680
to
9e78524
Compare
BruceWouaigne
changed the title
|
Would seem more natural to me if |
|
And it should be merged in 2.3 |
|
|
Thanks for working on this @BruceWouaigne! Looks good to me. |
|
Awesome! Thanks :) |
|
The other fixes of this kind have been merged into 2.3. So merging this into 2.8 seems wrong to me. |
fabpot
added a commit
that referenced
this pull request
Jun 27, 2015
…tener (BruceWouaigne) This PR was merged into the 2.3 branch. Discussion ---------- [Form] fixed sending non array data on submit to ResizeListener | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13804, #13851 | License | MIT | Doc PR | I agree with @Tobion that #13851 is a bug fix and therefore should be applied on the `2.3` branch too. Commits ------- 0f185c9 [Form] [EventListener] fixed sending non array data on submit to ResizeListener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.