[2.3+][Form][DoctrineBridge] Improved loading of entities and documents #13997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
guilhermeblanco
commented
Mar 20, 2015
guilhermeblanco
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #13961 |
| License | MIT |
| @@ -99,7 +99,7 @@ class EntityChoiceList extends ObjectChoiceList | |||
| * the choices are given as flat array. | |||
| * @param PropertyAccessorInterface $propertyAccessor The reflection graph for reading property paths. | |||
| */ | |||
| public function __construct(ObjectManager $manager, $class, $labelPath = null, EntityLoaderInterface $entityLoader = null, $entities = null, array $preferredEntities = array(), $groupPath = null, PropertyAccessorInterface $propertyAccessor = null) | |||
| public function __construct(ObjectManager $manager, $class, $labelPath = null, EntityLoaderInterface $entityLoader, $entities = null, array $preferredEntities = array(), $groupPath = null, PropertyAccessorInterface $propertyAccessor = null) | |||
There was a problem hiding this comment.
So not to break BC, would it make sense to leave $entityLoader is nullable and construct one using the required $manager and $class arguments?
$this->entityLoader = ($entityLoader !== null)
? $entityLoader
: $manager->getRepository($class)->createQueryBuilder('e');
There was a problem hiding this comment.
Oh, never mind. This would only create a query builder -- not an EntityLoader implementation.
…nd documents by reusing entity loader.
guilhermeblanco
force-pushed
the
entity-loader-fix
branch
from
ace9edd
to
529d99c
Compare
|
Thank you @guilhermeblanco. |
fabpot
added a commit
that referenced
this pull request
Mar 21, 2015
…and documents (guilhermeblanco) This PR was merged into the 2.3 branch. Discussion ---------- [2.3+][Form][DoctrineBridge] Improved loading of entities and documents | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13961 | License | MIT Commits ------- 529d99c Fixed MongoODM entity loader. Improved loading behavior of entities and documents by reusing entity loader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.