Replace GET parameters when changed in form #14010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wouterj
commented
Mar 21, 2015
wouterj
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #13962 |
| License | MIT |
| Doc PR | - |
| $query = parse_url($uri, PHP_URL_QUERY); | ||
| $currentParameters = array(); | ||
| if ($query) { | ||
| foreach (explode('&', $query) as $param) { |
There was a problem hiding this comment.
Could it be possible to replace these two combined explode functions + foreach by a call to the PHP parse_str() function?
There was a problem hiding this comment.
Unfortunately, as said on PHP.net:
Parses str as if it were the query string passed via a URL and sets variables in the current scope.
There is no easy (nor quick) way to find out which variables were added in the current scope IRCC
There was a problem hiding this comment.
But if you use the second optional argument of the function, the variables are stored in an array, right?
There was a problem hiding this comment.
Indeed, I've updated the PR.
|
Thank you @wouterj. |
fabpot
added a commit
that referenced
this pull request
Mar 23, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Replace GET parameters when changed in form | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13962 | License | MIT | Doc PR | - Commits ------- fa9fb5c Replace GET parameters when changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.