Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOM Crawler] Forms->getUri() returns incorrect value when having no action attribute and having get parameters in the original URI #13962

Closed
thijsBreker opened this issue Mar 18, 2015 · 0 comments

Comments

@thijsBreker
Copy link
Contributor

When having a form like this

<form method="get">
    <input type="checkbox" name="checkbox" value="x"/>
    <input type="text" name="field" value="y"/>
    <input type="submit"/>
</form>

On a page with the URL http://localhost/foo/bar?checkbox=x&text=y when I change the value of the text field to z and un-check the checkbox the URI returned by Form->getUri() is http://localhost/foo/bar?checkbox=x&text=y&text=z instead of the expected http://localhost/foo/bar?text=z

fabpot added a commit that referenced this issue Mar 23, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

Replace GET parameters when changed in form

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #13962
| License       | MIT
| Doc PR        | -

Commits
-------

fa9fb5c Replace GET parameters when changed
@fabpot fabpot closed this as completed Mar 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants