WIP [DebugBundle] Allow configuring a dumper while collecting dumps, add a default one writing to stderr when the cli-server is in use #14373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
added
the
DX
| if ('cli-server' === PHP_SAPI) { | ||
| $cloner = new VarCloner(); | ||
| $dumper = new CliDumper('php://stderr', $this->charset); | ||
| $dumper->dump($cloner->cloneVar(sprintf('In %s on line %d', $file, $line))); |
There was a problem hiding this comment.
shouldn't you just write to php://stderr instead of using the dumper ? Having all the info about the string does not make much sense IMO, and it could even get truncated by the dumper
There was a problem hiding this comment.
It's a shortcut to benefit from auto-selection of color support, but yes, it's possible.
There was a problem hiding this comment.
but does it need to be colored as dumped strings ? It would be confusing in case the dumped value is also a string
There was a problem hiding this comment.
I think so, but maybe in a different color/background. That's the kind of things we can tweak if the main idea is appealing to a majority.
|
👍 I like the idea. Mostly because I think it feels like the natural behavior that you'd expect when using the built-in web server and the My only concern is: will it become a mess if I output a lot of variables or few but complex variables? |
nicolas-grekas
changed the title
nicolas-grekas
force-pushed
the
dump-stderr
branch
from
a7d1a6b
to
f6e4455
Compare
nicolas-grekas
changed the title
nicolas-grekas
changed the title
nicolas-grekas
changed the title
nicolas-grekas
force-pushed
the
dump-stderr
branch
from
f6e4455
to
64d5cbe
Compare
nicolas-grekas
changed the title
nicolas-grekas
force-pushed
the
dump-stderr
branch
from
64d5cbe
to
013f549
Compare
fabpot
added a commit
that referenced
this pull request
May 15, 2015
…olas-grekas) This PR was merged into the 2.6 branch. Discussion ---------- [DebugBundle] Allow alternative destination for dumps | Q | A | ------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14608 | License | MIT | Doc PR | - This PR fixes #14608 by adding a new `debug.dump_destination` configuration option to give users control over a stream destination where dumps will be written to. In HTTP mode, dumps are still/also collected in the toolbar. This supersedes #14627, #14631 and #14373 Commits ------- 5f255e5 [DebugBundle] Allow alternative destination for dumps 5368483 [DebugBundle] Use output mechanism of dumpers instead of echoing 8cb2abb [DebugBundle] Always collect dumps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
dump()is called, you all know this happens:With this PR, dumps are duplicated in the console output of a
php -Sprocess:This does not work with php app/console server:run but that is for an other PR.