Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Translation][MessageCatalogue] use define whenever possible. #14433

Closed
wants to merge 1 commit into from
Closed

[Translation][MessageCatalogue] use define whenever possible. #14433

wants to merge 1 commit into from

Conversation

aitboudad
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets ~
Tests pass? yes
License MIT

@stof
Copy link
Member

stof commented Apr 21, 2015

why adding more method calls for the same thing ?

@aitboudad
Copy link
Contributor Author

@stof I made this change just to avoid duplication of code

@stloyd
Copy link
Contributor

stloyd commented Apr 22, 2015

👎 as you add overhead (little by still) for no reason as those are calls to internal variable. We should avoid it same as we avoid using sizeof() instead of count()...

@aitboudad
Copy link
Contributor Author

@stloyd agreed, so let close it :)

@aitboudad aitboudad closed this Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aitboudad @stof @stloyd