[Translation][Form][choice] Placeholder shouldn't be translated when empty #14997
Conversation
|
@webmozart I believe it's all ok now, but could you please take a look? Regards, |
|
Thanks for working on this @Restless-ET. Looks good! :) Could you please rebase this onto 2.3 and open a new PR for the 2.3 branch? We need to fix this in the earliest supported version. |
|
Closing for #15048 |
|
@Tobion The Bootstrap form theme is not part of Symfony 2.3. So we need this PR to at least update that test class. |
|
@xabbuh such things must be done when merging. The naming is different in this branch anyway (placeholder instead of empty_value). So you need to resolve conflicts. |
|
There is no point in having PRs for the same thing. |
|
@Tobion Will the merge take care of updating a test file that is (on a first glance) totally unrelated to the things fixed by the first PR? I understand that you will have to deal with the conflicts when merging branches. But I thought this PR should be kept for the 2.6 specific changes and could simply be rebased when the |
…lated when it has an empty value (Restless-ET) This PR was squashed before being merged into the 2.3 branch (closes #15048). Discussion ---------- [Translation][Form][choice] empty_value shouldn't be translated when it has an empty value | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The same fix provided at #14997 but against ```2.3``` branch. @webmozart As requested. :) Commits ------- 1a5c4c6 [Translation][Form][choice] empty_value shouldn't be translated when it has an empty value
|
Fixed as part of the merge. |
Without this I keep on getting the "missing messages" for an empty string at the Translation Profiler (like shown below) for every non-required
choiceField Type.PS - I'm aware that the Translation profiler is only available for SF 2.7+ but since the
placeholderoption is available for SF 2.6+ I'm creating this PR against branch 2.6