Fix missing _route parameter notice in RouterListener logging case #15392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which third party router do you use that does not set this parameter? I agree with this PR since the UrlMatcherInterface does not specify that a |
|
👍 |
fabpot
added a commit
that referenced
this pull request
Jul 29, 2015
…ing case (Haehnchen) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #15392). Discussion ---------- Fix missing _route parameter notice in RouterListener logging case | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | na | License | MIT | Doc PR | na `\Symfony\Component\HttpKernel\EventListener\RouterListener::onKernelRequest` missed test cases in logging condition. So if we provide routing matches without a `_route` parameter `notice` messages are thrown. In this case i added a check and use `n/a` for empty route names as this is also shown in profiler if it not exists. Commits ------- 0ce91a6 Fix missing _route parameter notice in RouterListener logging case
|
Merged into 2.3., thanks @Haehnchen |
|
fyi: using cmf routing, but replaced maching for a minimized cache. so no "third party router" issue. |
fabpot
added a commit
to silexphp/Silex
that referenced
this pull request
Sep 10, 2016
This PR was merged into the 2.0.x-dev branch. Discussion ---------- removed obsolete code (fixed in Symfony 2.3.32) That was fixed in symfony/symfony#15392 (so before 2.8.0). Commits ------- b12cdc4 removed obsolete code (fixed in Symfony 2.3.32)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\Symfony\Component\HttpKernel\EventListener\RouterListener::onKernelRequestmissed test cases in logging condition. So if we provide routing matches without a_routeparameternoticemessages are thrown. In this case i added a check and usen/afor empty route names as this is also shown in profiler if it not exists.