[ci] Use current PHP_BINARY when running ./phpunit #16121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // PHPUnit 4.8 does not support PHP 7, while 5.0 requires PHP 5.6+ | ||
| if (PHP_VERSION_ID >= 70000) { | ||
| $PHPUNIT_VERSION = '5.0'; | ||
| $PHP = ProcessUtils::escapeArgument($PHP); |
There was a problem hiding this comment.
will this work properly on HHVM ? Or are they exposing it as hhvm --php ?
There was a problem hiding this comment.
PHP_BINARY will not contain --php so it's ok
nicolas-grekas
force-pushed
the
php-bin-unit
branch
2 times, most recently
from
7990613
to
765b41f
Compare
nicolas-grekas
force-pushed
the
php-bin-unit
branch
from
765b41f
to
41aecbe
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 5, 2015
…las-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [ci] Use current PHP_BINARY when running ./phpunit | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This allows to easilly test with several php versions. I also added an auto-install of composer and the deps when they are not here. Should ease on-boarding devs to running tests. Commits ------- 41aecbe [ci] Use current PHP_BINARY when running ./phpunit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to easilly test with several php versions.
I also added an auto-install of composer and the deps when they are not here.
Should ease on-boarding devs to running tests.