-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Process] Fix signaling/stopping logic on Windows #16753
Conversation
nicolas-grekas
commented
Nov 30, 2015
Q | A |
---|---|
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | - |
License | MIT |
Doc PR | - |
0edc997
to
7152384
Compare
} | ||
// avoid exception here : | ||
// process is supposed to be running, but it might have stop | ||
// just after this line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(existing typo) "but it might have stopped just after this line."
5ef6b5c
to
2b672f4
Compare
$this->doSignal($signal ?: SIGKILL, false); | ||
} | ||
// Avoid exception here: process is supposed to be running, but it might have stopped just | ||
// after this line. In any case, let's silently discard the error, we can not do anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"can not" -> "cannot"
2b672f4
to
8012731
Compare
8012731
to
9afbea2
Compare
Yeeah, tests are green on appveyor! |
Thank you @nicolas-grekas. |
…-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [Process] Fix signaling/stopping logic on Windows | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 9afbea2 [Process] Fix signaling/stopping logic on Windows