Embedded identifier support #16826
Closed
Embedded identifier support #16826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test to prevent future regressions? Status: Needs work |
|
Sure, will come back with the test for this soon. I just want to make sure there's no counter opinion relating to this (such as "why would you use embedded objects as entity identifiers"). |
|
@sstok sorry for the delay, I added the suggested tests. |
|
Thank you @mihai-stancu. |
fabpot
added a commit
that referenced
this pull request
Dec 26, 2015
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #16826). Discussion ---------- Embedded identifier support | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | n/a If you define your entity identifier using an embeddable class the identifier name will contain period symbols in it such as `id.value` which will generate a syntax error in the DQL lexer because parameter names are not allowed to contain period symbols. Example to reproduce described bug: ```php /** * @Orm\Embeddable */ class Identifier { /** * @Orm\Column(type="integer") */ protected $value; } /** * @Orm\Entity */ class Entity { /** * @Orm\Id @Orm\Embedded(class="Identifier") */ protected $id; } ``` Commits ------- 38fdda6 Embedded identifier support
This was referenced Dec 26, 2015
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you define your entity identifier using an embeddable class the identifier name will contain period symbols in it such as
id.valuewhich will generate a syntax error in the DQL lexer because parameter names are not allowed to contain period symbols.Example to reproduce described bug: