[FrameworkBundle] [Routing] Check if default value matches requirement #16862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyFreeAgent
force-pushed
the
routing-default-value
branch
from
99b2c04
to
daa18f9
Compare
|
is it already enforced in other places and missing only in the cache warmer (and so the PR allows to give faster feedback), or is it currently possible to use a non-matching default ? |
|
Duplicate of #5664 and the proposed solution here cannot be used because it only triggers on framework bundle router and not in the routing component. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the default value defined in a route matches the requirement of that value.