[Routing] added route compile check to identify a default value... #5664
Conversation
|
@fabpot ping |
|
It breaks for instance symfony.com. We have a route like this: As you can see, there is a requirement on section and page, but they are both optional. With this PR, I have the following exception: "The default value "" of the required variable "section" in pattern "/doc/{version}/{section}/{page}/" does not match the requirement "[^/]+". This route definition makes no sense because this default can neither be used as default for generating URLs nor can it ever be returned by the matching process. You should change the default to something that meets the requirement or remove it." |
|
No, neither section nor page are optional because there is static text at the end (the trailing slash). If they were optional just And the exception is right. Because the default for section makes no sense (as the message explains). The default for page is ok because the requirement is |
|
This whole thing with implicit optional variables is pretty hard to grasp as they are only optional when they have a default AND are at the end of the pattern (so a single trailing slash makes a huge difference). If even you are confused it shows the big problem of this magic. This is one more reason for implementing #5424 as it is much more flexible and at the same time more explicit. |
|
@fabpot as the exception explains, you can safely remove the default for your |
…required variable that does not match the requirement
|
@fabpot ping |
|
This would help DX alot to understand strange route definitions. But as people already have route definitions that make no sense, this breaks BC for them. So closing. |
... of a required variable that does not match the requirement
reopened version of #5400