[DependencyInjection] fixed definition loosing property shared when decorated by a parent definition #16926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecorated by a parent definition
|
|
||
| $container | ||
| ->setDefinition('child', new DefinitionDecorator('parent')) | ||
| ->setShared(false) |
There was a problem hiding this comment.
IMO you should put this setShared(false) in the definition of the parent service in order to test if we pass the same shared value to their childrens.
There was a problem hiding this comment.
@dosten the shared flag is always taken from the child (same than the scope in 2.x, as this is the replacement for the scope)
|
Also noticed this bug while upgrading from 2.7 to 2.8. Would very much appreciate this patch in 2.8 👍 |
|
👍 |
|
Thank you @wahler. |
fabpot
added a commit
that referenced
this pull request
Dec 18, 2015
…ared when decorated by a parent definition (wahler) This PR was squashed before being merged into the 2.8 branch (closes #16926). Discussion ---------- [DependencyInjection] fixed definition loosing property shared when decorated by a parent definition | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | While upgrading my applications from 2.7 and 2.8 I found out that the attribute "shared" gets lost when a parent is configured. I wrote a Test to confirm my assumption and added a bugfix Commits ------- d3a4a77 [DependencyInjection] fixed definition loosing property shared when decorated by a parent definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading my applications from 2.7 and 2.8 I found out that the attribute "shared" gets lost when a parent is configured. I wrote a Test to confirm my assumption and added a bugfix