Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation] Fix incompatibility with php-memcache from Debian #17873

Conversation

ymc-dabe
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

The version of php-memcache (3.0.9~20151130.fdbd46b-1) in Debian makes
the test MemcacheSessionHandlerTest::testReadSession fail with the following
error message:

There was 1 error:

1) Symfony\Component\HttpFoundation\Tests\Session\Storage\Handler\MemcacheSessionHandlerTest::testReadSession
Missing argument 2 for Mock_Memcache_ddacd7a0::get(), called in /tmp/buildd/symfony/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/MemcacheSessionHandler.php on line 82 and defined

/tmp/buildd/symfony/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/MemcacheSessionHandler.php:82
/tmp/buildd/symfony/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MemcacheSessionHandlerTest.php:75

This PR solves the issue reported here.

The version of php-memcache (3.0.9~20151130.fdbd46b-1) in Debian makes
the test MemcacheSessionHandlerTest::testReadSession fail, complaining
about missing arguments. This commit solves this issue.
@ymc-dabe ymc-dabe force-pushed the HttpFoundation-Fix-incompatibility-with-php-memcache-from-Debian branch from f6b729c to 7ba0f24 Compare February 21, 2016 12:25
@ymc-dabe
Copy link
Contributor Author

I guess the actual problem lays in (Debian's) php-memcache. But since fixing this in Symfony itself was rather easy, I thought it was worth forwarding the patch upstream to the Symfony project. But I'm up to investigating this further and if applicable report a bug against php-memcache in Debian, if you think patching Symfony is the wrong way to deal with this issue.

@ymc-dabe ymc-dabe changed the title WIP: [HttpFoundation] Fix incompatibility with php-memcache from Debian [HttpFoundation] Fix incompatibility with php-memcache from Debian Feb 21, 2016
@fabpot
Copy link
Member

fabpot commented Feb 26, 2016

I'm not comfortable with this patch as it looks really weird. It should be fixed upstream instead IMHO.

@xabbuh
Copy link
Member

xabbuh commented Feb 27, 2016

I agree. This should be fixed in the Debian package instead.

@ymc-dabe
Copy link
Contributor Author

Actually it should be fixed in https://github.com/websupport-sk/pecl-memcache, which is Debian's upstream for php-memcache. I'll do a little testing later to validate if this still exists with recent master and open an issue at websupport-sk/pecl-memcache if needed (and a Bug for Debian's php-memcache anyhow). Thanks for your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants