Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a GitHub issue template to avoid support questions #20295

Closed
wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

We're getting a lot of issues that are in fact support questions. Should we give a try at defining a GitHub Issue template to try to minimize this problem?

The text contents are temporary. This is how they'd look:

issue_template

@wouterj
Copy link
Member

wouterj commented Oct 25, 2016

👎 For me, any boilerplate stuff I have to remove before I can actually start reporting my issue will make me report less issues. Issue templates are templates and not informative texts, imo.

@javiereguiluz
Copy link
Member Author

For what is worth, it's almost impossible to find a popular GitHub repository without an issue template:

bootstrap angular
react laravel

@chalasr
Copy link
Member

chalasr commented Oct 25, 2016

I'm 👍 for having an issue template, but (as pointed by @wouterj) for the same kind of templates we have for pull requests, helping to determinate if it is a bug report, a feature request, which version is concerned... So maintainers (especially @javiereguiluz) don't have to manually add labels on all issues. It should help to avoid support issues as well, as we are forced to define a concrete type (i.e. feature request or bug report, if it can't be in these two choices, then it's a support issue).

@sstok
Copy link
Contributor

sstok commented Oct 25, 2016

FYI, you can use html comments <!-- --> to hide instructions, Sonata does this for example.
They only show-up when editing but not when you post them.

https://raw.githubusercontent.com/sonata-project/dev-kit/master/project/.github/ISSUE_TEMPLATE.md

It would also be a good idea to use a questioner for issues:
Types (bug, feature), Symfony version, php version, etc.

@ro0NL
Copy link
Contributor

ro0NL commented Oct 26, 2016

So why not both?

<!--
* Some
* Guidelines..
-->

| Q             | A
| ------------- | ---

Issue templates are templates and not informative texts

This is a value used by default for each new issue. How is that not a template?

@wouterj
Copy link
Member

wouterj commented Oct 26, 2016

This is a value used by default for each new issue. How is that not a template?

Well, the proposed "template" is not a template at all. It just informs you that you shouldn't submit support questions. This is "informative text", which I'm against.

Please note that I'm not against introducing a Q/A table for issues. That's a great example of a template. (it indicates what type of issues Symfony wants in a template way and it doesn't formalize the way people type their feature requests too hard)

@ro0NL
Copy link
Contributor

ro0NL commented Oct 26, 2016

Ok, we interpret it differently :) From github's pov this is a issue template, whatever the file contents are. Anyway im 👍 on whatever helps creating better issues.

Lets focus on the QA first then? What about;

  • Bug report yes/no
  • Feature request yes/no
  • Symfony version x.y.z
  • PHP version x.y

More or less like @chalasr proposed.

@wouterj
Copy link
Member

wouterj commented Oct 26, 2016

I like it. I think we shouldn't add to much stuff in there. When looking at other issue templates, it seems like the proposed items covered the commonly used items.

So:

| Q                | A
| ---------------- | -----
| Bug report?      | yes/no
| Feature request? | yes/no
| Symfony version  | x.y.z
| PHP version      | x.y.z

@HeahDude
Copy link
Contributor

No need for a template when we have Carson :) What about:

<!--

Thanks for supporting Symfony!

* Issues are used for reporting bugs and requesting new features.

  To define which it is, just add "[Bug]" or "[Feature]" before the title of this issue.

  You can also target some specific component(s) with braces, i.e "[Form]" or "[Security]".

  When a bug is suspected, please mention the version of Symfony and PHP you're using.

  If some simple unit test are not enough, you can try to fork symfony/symfony-standard
  and add the minimum of code to reproduce your scenario.

* If you have a question about using Symfony, please check https://symfony.com/support

-->

?

@javiereguiluz
Copy link
Member Author

javiereguiluz commented Oct 27, 2016

I've just closed two support issues that may have not existed if we had explain to users that issues are not the way to ask questions: #20293 and #20318.

By the way, I don't like it at all to create a template where the bug reporter must fill in a lot of information. In that case I'd agree with this Wouter comment.

@ro0NL
Copy link
Contributor

ro0NL commented Nov 1, 2016

I like @HeahDude's idea to use carson [Bug/FR/Feature(Request)] for automatic labels. Which indeed requires no further template, just some general info. I think it's the most friendly/accessible, yet useful way to handle it.

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Nov 2, 2016

I don't like adding labels in issue titles, they are too often redundant with the title and clutter reading IMHO.

IMHO again, the short comment is a nice idea, looks like a perfect contextual help to me.

My 2cts:

| Q                | A
| ---------------- | -----
| Bug report?      | yes/no
| Feature request? | yes/no
| BC Break report? | yes/no
| RFC?             | yes/no
| Symfony version  | x.y.z

<!--
- Please fill in this template according to your issue.
- For support request or how-tos, please visit https://symfony.com/support
- Otherwise, replace this comment by the description of your issue.
-->

@fabpot
Copy link
Member

fabpot commented Nov 10, 2016

I like @nicolas-grekas suggestion.

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Dec 6, 2016
fabpot added a commit that referenced this pull request Dec 13, 2016
This PR was merged into the 2.7 branch.

Discussion
----------

[github] Tweak PR template

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Related to #20295

Commits
-------

2acaf5f [github] Tweak PR template
@nicolas-grekas
Copy link
Member

👍

1 similar comment
@stof
Copy link
Member

stof commented Dec 13, 2016

👍

@fabpot
Copy link
Member

fabpot commented Dec 13, 2016

Thank you @javiereguiluz.

fabpot added a commit that referenced this pull request Dec 13, 2016
…s (javiereguiluz)

This PR was squashed before being merged into the 2.7 branch (closes #20295).

Discussion
----------

Define a GitHub issue template to avoid support questions

We're getting a lot of issues that are in fact support questions. Should we give a try at defining a GitHub Issue template to try to minimize this problem?

The text contents are temporary. This is how they'd look:

![issue_template](https://cloud.githubusercontent.com/assets/73419/19683472/9be02128-9ab2-11e6-90a7-987ddcb49d97.png)

Commits
-------

eeaca5c Define a GitHub issue template to avoid support questions
@fabpot fabpot closed this Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants