Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBridge][Worklow] Added a new workflow_has_place function #21253

Merged
merged 4 commits into from
Jan 12, 2017

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Jan 12, 2017

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #20781
License MIT
Doc PR

This PR follow up #20781

I also increased the Coverage of the WorkflowExtension and finally I added an extra commit that is not related to clean-up 2 unused properties

@lyrixx lyrixx changed the title Workflow twig [TwigBridge][Worklow] Added a new workflow_has_place function Jan 12, 2017
@lyrixx lyrixx removed the BC Break label Jan 12, 2017
@lyrixx lyrixx added this to the 3.x milestone Jan 12, 2017
@stof
Copy link
Member

stof commented Jan 12, 2017

what about workflow_has_marked_place ? workflow_has_place looks like it asks whether the workflow has this place, which is not what the function does

@lyrixx
Copy link
Member Author

lyrixx commented Jan 12, 2017

@stof I totally agree with you. I have updated the code.

@fabpot
Copy link
Member

fabpot commented Jan 12, 2017

Thank you @lyrixx.

@fabpot fabpot merged commit 108c89d into symfony:master Jan 12, 2017
fabpot added a commit that referenced this pull request Jan 12, 2017
…unction (Padam87, lyrixx)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[TwigBridge][Worklow] Added a new workflow_has_place function

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20781
| License       | MIT
| Doc PR        |

---

This PR follow up #20781

I also increased the Coverage of the WorkflowExtension and finally I added an extra commit that is not related to clean-up 2 unused properties

Commits
-------

108c89d [TwigBridge] Removed unused class property
77f820e [TwigBridge][Workflow] Added more tests on WorkflowExtension
efe500d [TwigBridge][Workflow] Fixed code and tests
4d0cc68 [TwigBridge][Workflow] Added workflow_has_place twig function
@lyrixx lyrixx deleted the workflow-twig branch January 12, 2017 19:03
@lyrixx
Copy link
Member Author

lyrixx commented Jan 12, 2017

and thank you @Padam87 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants