[WIP] Revamp README #21272
Closed
[WIP] Revamp README #21272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jan 13, 2017
| [6]: https://symfony.com/doc/master/contributing/code/tests.html | ||
| [7]: https://symfony.com/doc/current/book/installation.html#installing-the-symfony-installer | ||
| [8]: https://symfony.com/doc/current/contributing/community/reviews.html | ||
| <div align="center"> |
There was a problem hiding this comment.
using HTML is a bad idea. This is a markdown file
There was a problem hiding this comment.
Markdown doesn't care with positioning. It has to be done with HTML or the image could be changed to Markdown but then I purpose to use this image and just leave it at the left.
Edit: You are right. This has been changed.
|
I'll leave this PR stalled for now since @javiereguiluz added a comment in the issue about approval from the symfony deciders. Additional work would destroy the time and effort. |
|
@Ricknox thanks! I'm going to lock this PR too until the related issue is approved to avoid duplicated comments. |
|
Let's close this PR until we know what to do. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request revamps the
README.mdfile based on all the feedback in the ticket. Currently, this PR is work in progress and should not be merged.