[DI] Dont trigger deprecation for event_dispatcher service

[chalasr]

Q	A
Branch?	master
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#22208
License	MIT
Doc PR	n/a

Mute deprecations for the event_dispatcher service keeping only relevant ones i.e when the api of the deprecated class is used intentionally, ugly but prevent breaking test suites like the LexikJWTAuthenticationBundle one.

[nicolas-grekas]

personally, I try to always add the @deprecated string to ease doing grep. I don't expect anyone to read all the source code looking for specific notices about 4.0 (or we'd expect to miss some for sure)

[nicolas-grekas]

👍 with minor comment

[chalasr]

@deprec annotation added

[nicolas-grekas]

👍

[fabpot]

Thank you @chalasr.

[garak]

This is not working for me. I'm on 3.3.0 and I still get deprecations, both in tests and in profiler: "The Symfony\Component\EventDispatcher\ContainerAwareEventDispatcher class is deprecated since version 3.3 and will be removed in 4.0. Use EventDispatcher with closure-proxy injection instead: 160x"

[chalasr]

@garak the deprecation you are getting is not the one fixed here.
Please open a new issue, with reproducer if possible (I just tried on a fresh SE with 3.3 and can't reproduce your problem).

[garak]

You can reproduce by installing KnpPaginatorBundle, so composer require knplabs/knp-paginator-bundle and adding new Knp\Bundle\PaginatorBundle\KnpPaginatorBundle(), in your AppKernel.
Even if you could think that the culprit is that bundle, I cannot find any evidence of ContainerAwareEventDispatcher in its source.
This is the relevant part of code where the deprecation notice is tracked, in appDevDebugProjectContainer.php:

protected function getDebug_EventDispatcherService()
{
        $this->services['debug.event_dispatcher'] = $instance = new \Symfony\Component\HttpKernel\Debug\TraceableEventDispatcher(new \Symfony\Component\EventDispatcher\ContainerAwareEventDispatcher($this), ${($_ = isset($this->services['debug.stopwatch']) ? $this->services['debug.stopwatch'] : $this->get('debug.stopwatch')) && false ?: '_'}, ${($_ = isset($this->services['monolog.logger.event']) ? $this->services['monolog.logger.event'] : $this->get('monolog.logger.event', ContainerInterface::NULL_ON_INVALID_REFERENCE)) && false ?: '_'});
// ...
}

[xabbuh]

I was not able to reproduce this by just adding the KnpPaginatorBundle to a blank Symfony 3.3 Standard Edition. Please open a new issue with steps to perform to be able to reproduce your issue if this persists for you.