[FrameworkBundle] Restore 3.2-like behavior for FormPass, to help BC with Sonata #22481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
changed the title
nicolas-grekas
force-pushed
the
sonata-formpass
branch
3 times, most recently
from
f060cd5
to
993ce0a
Compare
nicolas-grekas
force-pushed
the
sonata-formpass
branch
from
993ce0a
to
c97b08e
Compare
|
your proposal looks weird. Your PR on SonataCoreBundle would still alter the definition of |
|
About "private", that's the reason why the pass now calls |
|
Still 👍 here |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Apr 26, 2017
…to help BC with Sonata (nicolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle] Restore 3.2-like behavior for FormPass, to help BC with Sonata | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I tried updating a Sonata project to 3.3, and found it broken. The issue is that Sonata uses the constructor arguments of the `form.extension` to create its own `form.extension` service - but borrows its first args from the Symfony one. Here is the form pass doing that: https://github.com/sonata-project/SonataCoreBundle/blob/3.x/DependencyInjection/Compiler/FormFactoryCompilerPass.php And the implementation of the form extension: https://github.com/sonata-project/SonataCoreBundle/blob/3.x/DependencyInjection/SonataCoreExtension.php Question: is this covered by the BC policy? It shouldn't to me, because that would prevent *any* service reconfiguration. Thus, I'm proposing the attached patch, which basically reverts the deprecated `FormPass` in FrameworkBundle to its 3.2 state. I added a check to the new `FormPass` in the Form component so that it doesn't overwrite such compatibility configurations. See for corresponding fix on sonata-project/SonataCoreBundle#399 Commits ------- c97b08e [FrameworkBundle] Restore 3.2-like behavior for FormPass, to help BC with Sonata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried updating a Sonata project to 3.3, and found it broken.
The issue is that Sonata uses the constructor arguments of the
form.extensionto create its ownform.extensionservice - but borrows its first args from the Symfony one.Here is the form pass doing that:
https://github.com/sonata-project/SonataCoreBundle/blob/3.x/DependencyInjection/Compiler/FormFactoryCompilerPass.php
And the implementation of the form extension:
https://github.com/sonata-project/SonataCoreBundle/blob/3.x/DependencyInjection/SonataCoreExtension.php
Question: is this covered by the BC policy? It shouldn't to me, because that would prevent any service reconfiguration.
Thus, I'm proposing the attached patch, which basically reverts the deprecated
FormPassin FrameworkBundle to its 3.2 state.I added a check to the new
FormPassin the Form component so that it doesn't overwrite such compatibility configurations.See for corresponding fix on sonata-project/SonataCoreBundle#399